[Python-projects] Problems and fix for logilab-common (used via pylint)

[Sylvain Thénault]

On 12 mai 09:52, kevin gill wrote:

Hi,

please, use python-projects at lists.logilab.org mailing list for everything related
to our free software (CCed).

> I am trying out pylint with zope (with great success).
>
> I ran into a problem with namespace eggs
>
> I have eggs such as five.localsitemanager and five.grok. These have the  
> same namespace 'five'. pylint had problems finding five.grok if it  
> already found five.localsitemanager.
>
> I made two changes to modutils in logilab_common ver 0.39 to resolve  
> this problem...
>
> Line 580:
>
>            #_, mp_filename, mp_desc = find_module(modpath[0], path)
>            _, mp_filename, mp_desc = find_module("/".join(imported +  
> [modpath[0]]), None)

it's unclear to me what's fixed here but that's not the proper way to do it:
find_module prototype is : 'find_module(name, [path])' here you seems to give 
a path, not a module name as first argument. Moreover it changes the semantic
for what we're trying to acheive since we don't want it to search among all
sys.path.

In your install, five subpackages are eggs/zip or regular package directories ? 

> Line 627:
>
>            #return mod_or_pack + ext
>            return mod_or_pack + '.' + ext

this one has already been checked in our repository.

Thank you
-- 
Sylvain Thénault                               LOGILAB, Paris (France)
Formations Python, Debian, Méth. Agiles: http://www.logilab.fr/formations
Développement logiciel sur mesure:       http://www.logilab.fr/services
CubicWeb, the semantic web framework:    http://www.cubicweb.org