[Python-projects] [PATCH] Let pylint exit code indicate result of checks

Sylvain Thénault sylvain.thenault at logilab.fr
Wed Jan 28 11:36:02 CET 2009


Le Wednesday 28 January 2009 11:20:21 Mads Kiilerich, vous avez écrit :
> Sylvain Thénault wrote:
> > I've checked in your patch and enhanced it to have an option controlling
> > which messages will trigger non zero status code (we usually don't want
> > it for Information messages for instance).
>
> Ok.
>
> I generally prefer "do one thing and do it well" and KISS. So my take on
> that problem was that if there were some messages which shouldn't
> influence the exitcode then they should be disabled the usual way.
> Adding options for controlling which messages are fatal adds user
> interface complexity without adding real functionality.

well that's true though I started by ignoring messages in the Information 
category first, then read the ticket which was saying "return if any Error or 
Warning message issued", so I ended by adding this option... I actually 
hesitated since as you said you can somewhat controling it already using the 
disable-msg-cat option, but... If other people thinks the new option is 
useless and prefer a single disable-msg-cat option, I'll remove it.

> (Disclaimer: I haven't seen your change - apparently you haven't pushed
> it yet.)

it takes some times for changes in our internal repository to be propagated to 
the public repository. It should occurs sometime today.
-- 
Sylvain Thénault                               LOGILAB, Paris (France)
Formations Python, Zope, Plone, Debian:  http://www.logilab.fr/formations
Développement logiciel sur mesure:       http://www.logilab.fr/services
Python et calcul scientifique:           http://www.logilab.fr/science


More information about the Python-Projects mailing list